Builder support: MON-10, MON-11, MON-17#1
Conversation
| * @param cvc the CVC code | ||
| */ | ||
| public Card( | ||
| private Card( |
There was a problem hiding this comment.
- Revert to public modifier with
@deprecated - Deprecation message should be something like: use Card.create
- Also note that public constructor will be removed in future, in future versions
There was a problem hiding this comment.
@EnilPajic I'm interested in your opinion as well
| private Integer expMonth; | ||
| private Integer expYear; | ||
| private boolean tokenizePan; | ||
| private Map<String, Object> metaData; |
There was a problem hiding this comment.
Rename this field to 'data', meta is more data about entity itself. Data pushed to this field are more additional/non card data, not info about card itself.
| final Integer expMonth, | ||
| final Integer expYear, | ||
| final String cvc, | ||
| Map<String, Object> metaData) { |
There was a problem hiding this comment.
Rename every occurrence of 'metaData' to 'data'
| return this; | ||
| } | ||
|
|
||
| public Object getCountry() { |
There was a problem hiding this comment.
You should not design api in a way:
- field(TYPE)
- Object getField()
If field type is clearly set in setter same type should be as return type.
getCountry should return String not Object. Same stands for any other field. Also add @Nullable annotation (from android-x package)
|
|
||
| import java.util.Map; | ||
|
|
||
| public enum AdditionalData { |
There was a problem hiding this comment.
- additional data should be package local, not public
- field names should be constants within same file, package local visible
- Use field_name const in builder as well
| } | ||
| final String value = (String) fieldValue; | ||
| return value.matches(validationData) && value.length() >= minLength && value.length() <= maxLength; | ||
| case META_DATA_VALIDATION: |
There was a problem hiding this comment.
Rename META_DATA_VALIDATION to MAP_SIZE_VALIDATION
2 participants
No description provided.